removed macro internalErrSize#7046
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7046 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 79 79
Lines 14688 14689 +1
=======================================
+ Hits 14497 14498 +1
Misses 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 99b86cf Download link for the artifact containing the test results: ↓ atime-results.zip
|
aitap
reviewed
Jun 5, 2025
Contributor
Author
|
I don't know why the tests are failing. Everything works fine on my end |
Member
|
In the Microsoft Windows SDK, when compiling C code, <stdlib.h>
#defines the macros min() and max() in addition to the documented
Microsoft-specific macros __min() and __max() [1], unless __STDC__ is
pre-defined to a non-zero value (it's not) or _POSIX_ is defined
(neither it is). In MinGW, the SDK used by R on Windows as part of
Rtools [2], these definitions are disabled [3]; they are absent on
other systems.
[1]
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/min?view=msvc-170
[2]
https://cran.r-project.org/bin/windows/Rtools/
[3]
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/e1ff62d7f9acfbcb748e636f097fd2e6cc21d249/tree/mingw-w64-headers/crt/stdlib.h#l641
|
MichaelChirico
approved these changes
Jun 20, 2025
MichaelChirico
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the interest of continued improvements to readability, I've removed the unnecessary
internalErrSizemacro constant.